fix: Prevent turbo dev from hanging when daemon file watching fails#12091
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage Report
|
github-actions Bot
added a commit
that referenced
this pull request
Mar 2, 2026
## Release v2.8.13-canary.9 Versioned docs: https://v2-8-13-canary-9.turborepo.dev ### Changes - fix: Treat `npm: alias` dependencies as external, not workspace references (#12061) (`b179cb8`) - test: Port 18 more prysk tests to Rust (other/ + lockfile-aware-caching/) (#12062) (`7887af2`) - release(turborepo): 2.8.13-canary.8 (#12063) (`2a5522a`) - fix: Preserve file: protocol entries in pruned yarn v1 lockfile (#12064) (`ae5c1a1`) - perf: Use stack-allocated OidHash in FileHashes and skip expanded hashes on normal runs (#12065) (`677b248`) - test: Port all 8 find-turbo prysk tests to Rust (#12066) (`f827fca`) - fix: Support pnpm per-workspace lockfiles in turbo prune (#12067) (`23d047d`) - test: Port final 2 prysk tests to Rust (100% complete) (#12068) (`6d7e057`) - fix: Resolve Berry prune failure when resolutions contain patch overrides (#12069) (`6fe3c5e`) - test: Add lockfile fixture for yarn berry resolution pruning (issue #2791) (#12071) (`6cc1654`) - chore: Remove prysk test framework entirely (#12070) (`ed2d05a`) - refactor: Clean up test infrastructure and eliminate duplication (#12072) (`338911d`) - fix: Retain injected workspace package entries during pnpm lockfile pruning (#12073) (`acbe869`) - ci: Exclude turborepo-lsp and turborepo-schema-gen from test builds (#12075) (`4ce12e2`) - refactor: Clean up test infrastructure + improve test quality (#12074) (`4571f2b`) - ci: Remove redundant cargo build from coverage job (#12077) (`3c9bbe2`) - perf: Speed up lockfile test suite (#12078) (`20024df`) - ci: Remove integration test serialization (#12079) (`24d7c02`) - fix: Preserve `file:` and `link:` protocol entries in pruned bun lockfile (#12076) (`2635d9a`) - fix: Stop running unnecessary npm install in engines tests (#12081) (`24e4905`) - test: Add lockfile fixture for pnpm v9 injected workspace deps (issue #8243) (#12082) (`4d4929b`) - fix: Filter orphaned Yarn packageExtensions entries during lockfile pruning (#12084) (`68eb223`) - fix: Align experimentalObservability on object maps rather than arrays (#12089) (`9b9d1e4`) - examples: Upgrade with-react-native-web example to use latest versions (#12085) (`980ca43`) - fix: duplicate /signup? in Vercel URL (#12088) (`e865b51`) - ci: Deduplicate Rust test compilation with nextest archive (#12083) (`962cf39`) - fix: Prevent yarn integration tests from hanging on corepack prompts (#12090) (`29b0da7`) - fix: Prevent turbo dev from hanging when daemon file watching fails (#12091) (`b0d2f62`) - ci: Skip pnpm install for Rust test jobs (#12092) (`ebd137f`) - perf: Optimize npm lockfile parser (#12093) (`e4b4a66`) - chore: Trim unused dependency features for faster compilation (#12094) (`03b79e0`) - fix: Prevent lockfile-aware yarn test from hanging on corepack downloads (#12095) (`bf516e4`) - fix: Exclude turborepo-repository from JS smoke test in release workflow (#12097) (`fecc400`) --------- Co-authored-by: Turbobot <turbobot@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turbo devfrom hanging indefinitely when the daemon's file watcher fails to initializepackage_changesgRPC stream to properly close when the underlying broadcast channel is closedContext
Users upgrading from 2.8.10 to 2.8.11/2.8.12 reported that
turbo devhangs after printing the version number, showing no output and no error. The root cause is a chain of missing timeouts and error handling in the daemon's file watching pipeline.When the daemon's
FileSystemWatcherfails to initialize (e.g. FSEvents on macOS doesn't deliver events, cookie directory permission issues, or a stale daemon from a previous version), several things go wrong:PackageChangesWatchersubscriber waits forever onOptionalWatch::get()for file events that will never arrivepackage_changesstream handler loops onRecvError::Closedinstead of breaking, producing infinite error eventsWatchClient::start()blocks onevents.next().awaitwith no timeout, appearing frozenChanges
crates/turborepo-lib/src/run/watch.rs— Add a 10-second timeout when the client waits for the first event from the daemon'spackage_changesstream. Fails with an actionable error message instead of hanging.crates/turborepo-lib/src/package_changes_watcher.rs— Add a 5-second timeout to the subscriber's wait for file events to become ready. Previously waited indefinitely.crates/turborepo-daemon/src/server.rs— Fix thepackage_changesgRPC handler to distinguishRecvError::ClosedfromRecvError::Lagged. OnClosed, it now sends one error event and breaks out of the loop instead of spinning.crates/turborepo-filewatch/src/lib.rs— Upgrade file watcher initialization failure logs fromwarn!toerror!with guidance to runturbo daemon clean.Testing
Added 3 new tests:
optional_watch::test::get_returns_error_when_sender_dropped— Verifies error propagation when the sender drops without sendingoptional_watch::test::get_with_timeout_returns_elapsed_when_no_value— Verifies timeout behavior for the pattern used in the fixserver::test::package_changes_stream_closes_on_sender_drop— Reproduces the exact bug: broadcast sender drops, verifies the forwarding loop sends an error event and terminates instead of spinning